[0.8] fix observers - Githubissues

googlearchive / core-ajax

Polymer Core Ajax

26 stars 52 forks source link

[0.8] fix observers #99

Closed clintwood closed 9 years ago

clintwood commented 9 years ago

In this PR:

Update to use methods signature based observers array. Hookup handler bindings in created event since configure is no longer being called.

Now works with current Polymer 0.8-preview branch.

googlebot commented 9 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

clintwood commented 9 years ago

Hey @googlebot and friends, I've just signed the CLA... :)

googlebot commented 9 years ago

CLAs look good, thanks!

notwaldorf commented 9 years ago

I think @cdata had already moved this to https://github.com/PolymerElements/iron-ajax, which is the 0.8 version of core-ajax :(

clintwood commented 9 years ago

Oh man... Ok thanks for that!

notwaldorf commented 9 years ago

Really sorry about this! We're in the process of porting all the elements to the PolymerElements repo, so you should keep an eye on that for updates :)

Can you confirm iron-ajax works for you, and then I'll close this PR? Thanks!

clintwood commented 9 years ago

Ok sure will do! I have to say I'm finding the organisation of Polymer repos very difficult to keep track of... Anyhow, I do understand that things are in a mega flux!

Will report back as soon as I have a change to try out iron-ajax!

clintwood commented 9 years ago

Looks good, thanks closing here...