search

googlearchive / core-header-panel

Simple panel with top and bottom panes
9 stars 11 forks source link

Handle dynamic updates to mode property #11

Closed ebidel closed 10 years ago

ebidel commented 10 years ago

From http://stackoverflow.com/questions/25585929/panel-setattributemode-waterfall/25586138

One example is that core-header-panel adds a tall class to a child with the class core-header:

waterfall-tall

If mode is updated later on to mode = 'waterfall', the tall class sticks around. core-header-panel should do this cleanup.

gertcuykens commented 10 years ago

Would be great if you make it small again using a slide effect when doing the cleanup :) The same effect as when you scroll down.

frankiefu commented 10 years ago

fixed by https://github.com/Polymer/core-header-panel/commit/29650b69afaff5f3ef4b2a139b6c5f16fd818ede