search

googlearchive / core-icons

core-icons
41 stars 18 forks source link

Add GitHub to social icon set #3

Closed sattvik closed 10 years ago

sattvik commented 10 years ago

Hello,

I was playing around a bit with Polymer, and I felt like it was missing a GitHub icon, so I created one. This should fit in with the various post-* icons. I used GitHub's blacktocats.ai as a source for the octocat image and made it the icon resemble the favicon.ico on GitHub's page.

I don't know if anyone else would be interested in it, but just in case, I created this pull request.

Sincerely,

Daniel

ebidel commented 10 years ago

Before this PR can be merged, please sign the CLA. See the CONTRIBUTING guide.

sattvik commented 10 years ago

Hello, just letting you know I electronically signed the contributor agreement. I am also checking with GitHub to ensure that use of the octocat is fine.

dfreedm commented 10 years ago

Currently talking with our design team to make sure this fits the look and feel.

sattvik commented 10 years ago

Great, thanks. I'd be happy to update it if need be.

ebidel commented 10 years ago

@sattvik what email are you using for commits? Our script isn't picking you up.

sattvik commented 10 years ago

@ebidel It's daniel@solanogomez.org

ebidel commented 10 years ago

Thanks for signing the CLA!

dfreedm commented 10 years ago

Got the OK from designers, but the move from iconsets folder broke the PR. I'll apply manually.

dfreedm commented 10 years ago

Rebased into https://github.com/Polymer/core-icons/commit/35532efecad24e217069745b30ea27ae2b17e92b and merged