search

googlearchive / core-list

Polymer virtualized list element
25 stars 20 forks source link

Use translate instead of translate3d to avoid text blurring #71

Open JanMiksovsky opened 9 years ago

JanMiksovsky commented 9 years ago

core-list currently uses the translate3d transform to position items, but use of this transform is known to blur text. In trying to adopt the use of core-list to speed up Component Kitchen's main component catalog page, we're seeing this text blurring problem in both Chrome and WebKit.

Here's a snapshot taken in Chrome comparing normal text and the same text blurred by translate3d when trying to use core-list. It's likely that font and color choices determine the degree of blurring.

This PR replaces use of translate3d with the simpler translate transform. (The core-list code was never setting the translate's Z parameter, so the simpler 2D translate should work just as well.) This change fixes the blurring problem in both Chrome and WebKit. I've checked the core-list project's own demo in Chrome, Safari, Firefox, and IE 11, and don't see any regressions.

googlebot commented 9 years ago

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

JanMiksovsky commented 9 years ago

I signed Google's CLA back in February 2013. I think there was an issue in which the email address associated with my GitHub commits was no longer associated with the CLA, but I've fixed that.

googlebot commented 9 years ago

CLAs look good, thanks!