search

googlearchive / core-menu-button

An icon button that opens a drop-down menu.
6 stars 10 forks source link

Menu Item Remains Selected After Menu Closed #13

Open phidias51 opened 10 years ago

phidias51 commented 10 years ago

I created a menu using the core-menu-button and the core-item components. Whenever I select a menu item, and the menu disappears, the next time I open the menu, my previous selection remains selected. This makes it impossible to reselect the same menu item.

morethanreal commented 10 years ago

If a selected menu item is selected again, it will not fire core-select by design. If you need to reset the selection, you can clear the selected property manually when the menu closes.

phidias51 commented 10 years ago

Why is this "by design"? This isn't the way that menu's work on desktop apps, why would a user (or a developer for that matter) expect them to work that way?

Cheers,

Mark

On Tue, Sep 16, 2014 at 1:00 PM, Yvonne Yip notifications@github.com wrote:

If a selected menu item is selected again, it will not fire core-select by design. If you need to reset the selection, you can clear the selected property manually when the menu closes.

— Reply to this email directly or view it on GitHub https://github.com/Polymer/core-menu-button/issues/13#issuecomment-55804487 .

sjmiles commented 10 years ago

@morethanreal I think phidias51 is right. Let's work out a way to repair this in core-menu(-*).

morethanreal commented 10 years ago

We can probably make this an option in the various dropdown menus. I'm thinking the <select>-like elements (*-dropdown-menu) can have sticky selection by default, while menu buttons don't.

morethanreal commented 10 years ago

Fixed in 2aadfcb. There is now a stickySelection property that defaults to false.

arthurevans commented 9 years ago

It appears that stickySelection was removed when the menu button was refactored. Was this by design?

morethanreal commented 9 years ago

It's probably an oversight.