googlearchive / core-overlay

A custom element that renders on top of other content.
6 stars 20 forks source link

Stack overflow when closing a dialog while toast is shown #5

Closed RamCohen closed 10 years ago

RamCohen commented 10 years ago

If showing a paper-toast from a paper-dialog and then calling .opened=false on the dialog before the toast disappears a stack overflow occurs.

This happens in core-overlay:

  1. applyFocus if called with this.opened = false;
  2. focusOverlay() is called and is calling currentOverlay()
  3. currentOverlay returns with the same object being blurred
  4. applyFocus is again called ...
sorvell commented 10 years ago

@nevir I know you looked into some related issues. Mind taking a stab at this?

nevir commented 10 years ago

Should be fixed via #3