search

googlearchive / core-overlay

A custom element that renders on top of other content.
6 stars 20 forks source link

Return closed dialog to it's original position #57

Open winhowes opened 9 years ago

winhowes commented 9 years ago

The next sibling should not be the same as the parent, but because we're checking whether or not they're the same, the element is being appended into the parent rather than re-inserted where it was. This is in response to https://github.com/Polymer/polymer/issues/1218

googlebot commented 9 years ago

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

winhowes commented 9 years ago

Signed

googlebot commented 9 years ago

CLAs look good, thanks!