search

googlearchive / core-overlay

A custom element that renders on top of other content.
6 stars 20 forks source link

Update core-overlay.html #6

Closed RamCohen closed 10 years ago

RamCohen commented 10 years ago

Fix for issue #5 (Stack overflow when closing a dialog while toast is shown)

RamCohen commented 10 years ago

Is someone else reviewing this ?

robdodson commented 10 years ago

ping @sorvell @morethanreal

sorvell commented 10 years ago

Thanks for the PR. Before accepting it, I want to make sure there's not a more fundamental fix needed here.

nevir commented 10 years ago

I think we should go with the approach in #3 (or similar) to tackle the root cause (visual state mismatch w/ internal state)