search

googlearchive / core-pages

Simple content switcher
7 stars 6 forks source link

nested core-pages are always visible #14

Open jakemac53 opened 10 years ago

jakemac53 commented 10 years ago

see https://github.com/dart-lang/core-elements/issues/128

fedy2 commented 10 years ago

Here an example: https://ele.io/fedy2/filthy-coffee

jakemac53 commented 10 years ago

Looks like it is caused because of how the visibility css attribute works. Children who have visibility: visible will appear even if their parent has visibility: hidden. This could probably just be changed to use display: none instead of visibility: hidden, but I don't know if there are other reasons that it wasn't done that way in the first place?

Nevraeka commented 9 years ago

display: none; would be simpler but performance might not work out so well. Have we considered an 'offscreen' classname with 'aria-hidden' toggles?

Nevraeka commented 9 years ago

cc @azakus

cdata commented 9 years ago

@Nevraeka could you clarify your performance concern regarding display: none;?

There are a couple of ways we could potentially skin this cat without using display: none;. Automatic aria-hidden behavior could be added as well, although that sounds orthogonal to the current issue.