search

googlearchive / core-scaffold

A general application layout containing a header, toolbar, menu, title and areas for application content
17 stars 16 forks source link

Add rightDrawer passthrough property #9

Closed silenceisgolden closed 10 years ago

silenceisgolden commented 10 years ago

There does not seem to be a way to set a rightDrawer on core-scaffold's core-drawer-panel element. A published property needs to be added to core-scaffold to enable this.

silenceisgolden commented 10 years ago

The core-icon-button should also be repositioned to the right side as well in my opinion, but that would be subject to this issue https://github.com/Polymer/core-toolbar/issues/8.

albeec13 commented 10 years ago

@silenceisgolden It appears the version of core-scaffold on polymer-project.org is not the latest version from this repository.

The current version has the rightDrawer property exposed and functional.

Regarding your second issue about positioning the button on the right side, it's only partially addressed by the fix for Polymer/core-toolbar#8, due to the fact that the new justify property for core-toolbar is not exposed in core-scaffold. (This brings up a much more general issue about attribute pass-through that I won't elaborate on here.)

I added pull request #15 to move the button to the right side of the content when using rightDrawer, but you would have to add content with flex applied to push the button to the right. See #15 for details, and an example here: http://jsbin.com/pebudohubafi/1/edit

More elaborate example here: http://jsbin.com/saweqesozuki/1/edit

frankiefu commented 10 years ago

fixed by https://github.com/Polymer/core-scaffold/pull/15

silenceisgolden commented 10 years ago

@albeec13 Thanks for the response, sorry I missed it. I'm not currently using this element so its not in my immediate purview so however you all want to handle the issue is fine. The issue turned out to be more of an observance than a need. Thanks for looking at it!