Currently, https://github.com/Polymer/core-scroll-header-panel has the same behaviour as https://github.com/Polymer/core-header-panel: they both need the parent element to have an explicit height set on it or the content will wind up invisible. However, the warning about this requirement only appears in the documentation for Core-Header-Panel and not for Core-Scroll-Header-Panel, and the latter doesn't mention (as far as I know) that it is based on the other (or related to it). Thus the requirement for setting an explicit height on Core-Scroll-Header-Panel's parent element isn't clear from its documentation.
Just thought I'd suggest that this warning be added to the documentation for Core-Scroll-Header-Panel just like it currently exists in Core-Header-Panel. I wasted an hour or so scratching my head when I was playing around with Core-Scroll-Header-Panel until I discovered that it has the same requirements as Core-Header-Panel -- but perhaps that's because I'm dumb! :-)
frankiefu
commented
10 years ago
Hi friends,
Currently, https://github.com/Polymer/core-scroll-header-panel has the same behaviour as https://github.com/Polymer/core-header-panel: they both need the parent element to have an explicit height set on it or the content will wind up invisible. However, the warning about this requirement only appears in the documentation for Core-Header-Panel and not for Core-Scroll-Header-Panel, and the latter doesn't mention (as far as I know) that it is based on the other (or related to it). Thus the requirement for setting an explicit height on Core-Scroll-Header-Panel's parent element isn't clear from its documentation.
Just thought I'd suggest that this warning be added to the documentation for Core-Scroll-Header-Panel just like it currently exists in Core-Header-Panel. I wasted an hour or so scratching my head when I was playing around with Core-Scroll-Header-Panel until I discovered that it has the same requirements as Core-Header-Panel -- but perhaps that's because I'm dumb! :-)