search

googlearchive / core-scroll-header-panel

Fancy scrolling effects where the header animates between tall and condensed states
19 stars 16 forks source link

Documentation for attributes #2

Closed nevir closed 10 years ago

nevir commented 10 years ago

The interaction between tallMode and minHeaderHeight was a bit confusing - what do you think about renaming them to condenses and condensedHeaderHeight?

Otherwise, here's some quick documentation; I think this follows the latest style you folk are using for attribute docs?

ebidel commented 10 years ago

Thanks for the docs! cc @frankiefu to take a look on the API changes.

frankiefu commented 10 years ago

Yeah I like the suggestions. Thanks for the docs.

ebidel commented 10 years ago

@frankiefu has been busy. It looks like this will need rebasing

frankiefu commented 10 years ago

merged in here: https://github.com/Polymer/core-scroll-header-panel/commit/dcad5ded4814af1e2753fadb3bc62c4925323cfc