search

googlearchive / core-scroll-header-panel

Fancy scrolling effects where the header animates between tall and condensed states
19 stars 16 forks source link

Randomly working and not working correctly #24

Closed TimWillis closed 9 years ago

TimWillis commented 9 years ago

In the domReady event it calls this.async('measureHeaderHeight'), which then sets this.headerHeight to header.offsetHeight even if headerHeight is already set. if measureheaderheight is called to early(which it is randomly on chrome 37.0.2062.120 m) this results in header.offsetHeight being 0, causing the scroll not to work correctly. Could be an issue with this.async.

frankiefu commented 9 years ago

In #master we have already fixed it so if headerHeight is already set and header.offsetHeight is 0 it would not set the headerHeight to 0. This may help the issue you are seeing.

TimWillis commented 9 years ago

Yes, I bet it will, I put the same condition on my local version of the code and it works fine. Just wanted to let you guys know.

Thanks Tim

On Wed, Sep 24, 2014 at 3:35 PM, Frankie Fu notifications@github.com wrote:

In #master we have already fixed it so if headerHeight is already set and header.offsetHeight is 0 it would not set the headerHeight to 0. This may help the issue you are seeing.

— Reply to this email directly or view it on GitHub https://github.com/Polymer/core-scroll-header-panel/issues/24#issuecomment-56725852 .

frankiefu commented 9 years ago

Cool. The fix will be in the next release probably 0.4.2