search

googlearchive / core-scroll-header-panel

Fancy scrolling effects where the header animates between tall and condensed states
19 stars 16 forks source link

Main content shouldn't require content attribute #27

Closed arthurevans closed 9 years ago

arthurevans commented 9 years ago

It's confusing that this control requires the main content to have an explicit class or attribute, while the otherwise parallel core-header-panel has content select="*" for its main content area.

The way it's currently written (main content area defined first in the DOM), we can't use select="*". Could we get the same effect by using select=":not(core-toolbar):not(.core-header)"? Or would that be bad?

Related SO question: http://stackoverflow.com/questions/26522618/scroll-header-panel-inside-scaffold/26556766#26556766

Moved from Polymer/core-header-panel#18 (opened in wrong repo).

frankiefu commented 9 years ago

Good call. Initially :not was not supported in <content select= so we didn't use that. But now is supported in ShadowDom we should not need to require content attribute anymore.