search

googlearchive / core-scroll-header-panel

Fancy scrolling effects where the header animates between tall and condensed states
19 stars 16 forks source link

Add attribute 'fullWindow' #35

Open sidkat opened 9 years ago

sidkat commented 9 years ago

The attribute 'fullWindow' can be set if <core-scroll-header-panel> is used as a 'global' component containing all other visible components (except an optional <core-drawer-panel>!).

Setting this attribute fixes issues #1, #15 and #16.

It (optionally) enables "document scroll" (see the discussion here).

googlebot commented 9 years ago

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

sidkat commented 9 years ago

CLA signed

googlebot commented 9 years ago

CLAs look good, thanks!

ebidel commented 9 years ago

Left two important comments. cc @frankiefu