search

googlearchive / core-scroll-header-panel

Fancy scrolling effects where the header animates between tall and condensed states
19 stars 16 forks source link

Force core-toolbar/core-header to be transparent #7

Closed robdodson closed 9 years ago

robdodson commented 10 years ago

Because core-toolbar now has a default background (aa8b336327958382adcae3dcfc43a9cf27292ebc) it breaks core-scroll-header-panel since the background color was previously transparent (https://github.com/Polymer/polymer/issues/576). This change forces the content inside of #headerContent (either core-toolbar or .core-header) to be transparent again.

Fixes https://github.com/Polymer/polymer/issues/576

frankiefu commented 10 years ago

This will not work for the case that I just want to set background-color on core-toolbar, e.g. https://github.com/robdodson/core-scroll-header-panel/blob/master/demos/demo1.html#L46

frankiefu commented 10 years ago

For now, maybe just fix the demo so core-toolbar has background-color transparent (https://github.com/Polymer/core-scroll-header-panel/blob/master/demo.html#L56)?

robdodson commented 10 years ago

Hm that's kind of a bummer.

I wish there was a way to automatically set the toolbar to transparent if an image background is used

frankiefu commented 10 years ago

Yeah that's a bummer