googlearchive / core-selector

Manages a list of elements that can be selected
9 stars 14 forks source link

default selectedAttribute disrupts paper-item animation #26

Open atotic opened 9 years ago

atotic commented 9 years ago

Demo: http://jsbin.com/zohune/25/edit?html,js,output Click on Item 1. Animation never terminates on first click.

If you have a paper-item inside a core-selector, paper-item ripple animation never terminates first time you click on it. The cause is: core-selector sets paper-item.active which triggers paper-item.activeChanged which fires paper-ripple.downAction which starts a new ripple, that never completes, because there is no complementary upAction

Workaround: set core-selector selectedProperty to something else

Suggestion: rename default selectedProperty to something else, as paper-item inside core-selector is very common, and bug is not obvious when you encounter it.

PS: if this is Yip reviewing this bug, can you DM me at a@totic.org

JosefJezek commented 9 years ago

:+1: