search

googlearchive / core-splitter

A split bar and dragging on it will resize the sibling element
10 stars 12 forks source link

core-splitter for Polymer 1.0 #18

Open eximius313 opened 8 years ago

eximius313 commented 8 years ago

Any plans about migrating this component to 1.0?

JC-Orozco commented 8 years ago

I ported this element to Polymer 1.0 https://github.com/JC-Orozco/iron-splitter I also sent a pull request.

eximius313 commented 8 years ago

@JC-Orozco - the problem is, that your new version somehow still depends on old Polymer:

$ bower install --save JC-Orozco/iron-splitter
bower iron-splitter#*       not-cached git://github.com/JC-Orozco/iron-splitter.git#*
bower iron-splitter#*          resolve git://github.com/JC-Orozco/iron-splitter.git#*
bower iron-splitter#*         download https://github.com/JC-Orozco/iron-splitter/archive/0.5.6.tar.gz
bower iron-splitter#*          extract archive.tar.gz
bower core-splitter#*     invalid-meta core-splitter is missing "main" entry in bower.json
bower core-splitter#*     invalid-meta core-splitter is missing "ignore" entry in bower.json
bower core-splitter#*         resolved git://github.com/JC-Orozco/iron-splitter.git#0.5.6
bower core-resizable#^0.5   not-cached git://github.com/Polymer/core-resizable.git#^0.5
bower core-resizable#^0.5      resolve git://github.com/Polymer/core-resizable.git#^0.5
bower polymer#^0.5              cached git://github.com/Polymer/polymer.git#0.5.6
bower polymer#^0.5            validate 0.5.6 against git://github.com/Polymer/polymer.git#^0.5
bower core-resizable#^0.5     download https://github.com/Polymer/core-resizable/archive/0.5.6.tar.gz
bower polymer#^0.5             skipped webcomponentsjs
bower polymer#^1.0.0        not-cached git://github.com/polymer/polymer.git#^1.0.0
bower polymer#^1.0.0           resolve git://github.com/polymer/polymer.git#^1.0.0
bower polymer#^1.2              cached git://github.com/Polymer/polymer.git#1.2.4
bower polymer#^1.2            validate 1.2.4 against git://github.com/Polymer/polymer.git#^1.2
bower polymer#^1.2             skipped webcomponentsjs
bower polymer#~1.0.3            cached git://github.com/Polymer/polymer.git#1.0.9
bower polymer#~1.0.3          validate 1.0.9 against git://github.com/Polymer/polymer.git#~1.0.3
bower polymer#~1.0.3           skipped webcomponentsjs
bower polymer#^1.2.0            cached git://github.com/Polymer/polymer.git#1.2.4
bower polymer#^1.2.0          validate 1.2.4 against git://github.com/Polymer/polymer.git#^1.2.0
bower polymer#^1.2.0           skipped webcomponentsjs
bower polymer#^1.2.3            cached git://github.com/Polymer/polymer.git#1.2.4
bower polymer#^1.2.3          validate 1.2.4 against git://github.com/Polymer/polymer.git#^1.2.3
bower polymer#^1.2.3           skipped webcomponentsjs
bower polymer#^1.2.1            cached git://github.com/Polymer/polymer.git#1.2.4
bower polymer#^1.2.1          validate 1.2.4 against git://github.com/Polymer/polymer.git#^1.2.1
bower polymer#^1.2.1           skipped webcomponentsjs
bower core-component-page#^0.5  cached git://github.com/Polymer/core-component-page.git#0.5.6
bower core-component-page#^0.5         validate 0.5.6 against git://github.com/Polymer/core-component-page.git#^0.5
bower core-resizable#^0.5               extract archive.tar.gz
bower core-resizable#^0.5          invalid-meta core-resizable is missing "main" entry in bower.json
bower core-resizable#^0.5          invalid-meta core-resizable is missing "ignore" entry in bower.json
bower core-resizable#^0.5              resolved git://github.com/Polymer/core-resizable.git#0.5.6
bower core-component-page#^0.5          skipped webcomponentsjs
bower polymer#^1.0.0                   download https://github.com/polymer/polymer/archive/v1.2.4.tar.gz
bower polymer#^1.0.0                    extract archive.tar.gz
bower polymer#^1.0.0                   resolved git://github.com/polymer/polymer.git#1.2.4
bower polymer#^1.0.0                    skipped webcomponentsjs
bower                                 ECONFLICT Unable to find suitable version for polymer
JC-Orozco commented 8 years ago

I was manually installing and testing (not using bower). But let me review this...

Use this command to try the element: bower install JC-Orozco/iron-splitter#master More detailed explanation below:

There is something strange going on. I am able to install with bower using either master branch or my development branch jc-iron-splitter but not when not specifying a branch: This works for me: $ bower install JC-Orozco/iron-splitter#jc-iron-splitter Even this works OK: $ bower install JC-Orozco/iron-splitter#master But this retrieves core-splitter packages: $ bower install JC-Orozco/iron-splitter

The problem seems to be that bower is retrieving by default the tag 0.5.6, I created a new tag 1.0.0-rc but bower insists on retrieving tag version 0.5.6 by default!

$ bower install JC-Orozco/iron-splitter
bower cached git://github.com/JC-Orozco/iron-splitter.git#0.5.6
bower validate 0.5.6 against git://github.com/JC-Orozco/iron-splitter.git#*

...

eximius313 commented 8 years ago

I also don't have any idea why is that happening :(

JC-Orozco commented 8 years ago

You should be able to install and test this element using the next command using a tag reference: bower install JC-Orozco/iron-splitter#1.0.0-rc

JC-Orozco commented 8 years ago

I found the problem. It seems that bower ignores tags with rc (In this case 1.0.0-rc). Made a new 1.0.0 tag and now the default bower installation works OK: bower install JC-Orozco/iron-splitter

eximius313 commented 8 years ago

Ok, 

bower install --save JC-Orozco/iron-splitter

works now