search

googlearchive / core-splitter

A split bar and dragging on it will resize the sibling element
10 stars 12 forks source link

Core-Splitter does not function properly after a dialog closes. #9

Closed freeformflow closed 9 years ago

freeformflow commented 9 years ago

Hi Polymer Team, We've found an issue with the core-splitter component. The splitter will not function properly after a dialog has been opened and then closes. The splitter can still be moved, but if the cursor slips off the element, the splitter stops moving. The splitter can be moved while a dialog is open without issue, but something happens after the dialog is closed. We did not find an obvious problem in the components's JS, but something is stopping 'track()' from being called.

The problem is isolated and reproducible in the following example.: http://jsbin.com/lomaz/4/edit

Thank you!

frankiefu commented 9 years ago

When core-overlay closes it tries to remove the tap event listener from the document (https://github.com/Polymer/core-overlay/blob/master/core-overlay.html#L358). This is fine but seems like this also somehow removes the event listeners added by polymer-gestures on the document. And because of that track stops working correctly after that. Assigning to @azakus.

cc @sorvell

dfreedm commented 9 years ago

Fixed by https://github.com/Polymer/polymer-gestures/commit/3e51c5e51aced88790a03bbc06ca6ccda8038956

freeformflow commented 9 years ago

Thank you guys so much! That was so fast!