search

googlearchive / core-toolbar

Basic toolbar
7 stars 10 forks source link

class="middle" not center aligned on medium-tall toolbar #14

Closed arthurevans closed 9 years ago

arthurevans commented 9 years ago

I'm not sure whether this is a code issue or a documentation issue, but class="middle" doesn't work as I expected on a medium-tall toolbar. The #middleBar container is positioned at the bottom of the toolbar. If class="middle" is expected to work on tall bars, we should document that explicitly. (i.e., medium-tall bars are double-height and can take controls in the .top and .bottom containers; tall bars are triple-height and take .top, .middle and .bottom content.)

arthurevans commented 9 years ago

Related SO question: http://stackoverflow.com/questions/26553975/how-do-i-get-vertical-centering-in-a-core-toolbar-polymer-component/26555698#26555698

caiowilson commented 9 years ago

middleJustify does not work. :cake:

for now only Athur solution on SO works.

frankiefu commented 9 years ago

Sorry I was not very clear. We fixed the documentation as it is intended behavior. Arthur's solution is still the way if you need to center-aligned item vertically. middleJustify was already there before this and it is for controlling how the items are aligned horizontally when they are placed in the middle bar.

caiowilson commented 9 years ago

oh, then yes, doc fixed. no vertical centering on medium-tall coming huh? Thanks anyway :+1: btw you should say middleJustify with vertical layout, i guess, can't be wrong being as clearer as crap :)