search

googlearchive / core-toolbar

Basic toolbar
7 stars 10 forks source link

Give core-toolbar a default background color #3

Closed robdodson closed 10 years ago

robdodson commented 10 years ago

I'd like to add a default grey background color to core-toolbar so it's very clear to a new user that they have successfully added one to their page. Right now, core-toolbar is transparent, which can initially lead people to think that they've messed something up when they just get a blank screen. I realize this may mean going back to some of our demos which rely on the transparent behavior of core-toolbar and updating them to specifically not have a background, but I think/hope the trade-off is worth it for the increased feedback to new users.

ebidel commented 10 years ago

+1 This came up a lot when people were doing the codelab.

On Sat, Jun 28, 2014 at 7:58 AM, Rob Dodson notifications@github.com wrote:

I'd like to add a default grey background color to core-toolbar so it's very clear to a new user that they have successfully added one to their page. Right now, core-toolbar is transparent, which can initially lead people to think that they've messed something up when they just get a blank screen. I realize this may mean going back to some of our demos which rely on the transparent behavior of core-toolbar and updating them to specifically not have a background, but I think/hope the trade-off is worth

it for the increased feedback to new users.

You can merge this Pull Request by running

git pull https://github.com/robdodson/core-toolbar background-color

Or view, comment on, or merge it at:

https://github.com/Polymer/core-toolbar/pull/3 Commit Summary

  • Give core-toolbar a default background color

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/Polymer/core-toolbar/pull/3.

enriquemorenotent commented 10 years ago

Great. I was just thinking this. How long until this is published in bower? I just checked it out, and it is still transparent.

robdodson commented 10 years ago

We'll have to do a 0.3.4 release. Not sure when that will go out but hopefully soon. In the meantime, if you do a bower cache clean and set the dependency in your bower.json to look like this:

"core-toolbar": "Polymer/core-toolbar#master"

It will pull the latest from master. Just be sure to go back and change it when the next release goes out.

enriquemorenotent commented 10 years ago

I did not know I could do that! Cool!

Thanks for the tip.