googlearchive / core-toolbar

Basic toolbar
7 stars 10 forks source link

Core-toolbar breaking material design speck #7

Open tjsavage opened 10 years ago

tjsavage commented 10 years ago

Core toolbar component from: http://www.polymer-project.org/components/paper-elements/demo.html#core-toolbar does not align with the grid mentioned at: http://www.google.com/design/spec/layout/metrics-and-keylines.html#metrics-and-keylines-keylines-and-spacing

According to the speck on mobile devices: "Vertical keyline at 16 dp from the left and right edges. Content associated with an icon or avatar aligns 72 dp from the left edge. 16 dp horizontal margins on mobile." See image: http://material-design.storage.googleapis.com/images/layout-metrics-keylines-keylines-spacing-mobile-01bb_large_mdpi.png On tablet the padding to the first menu icon should be of 24 dp: http://material-design.storage.googleapis.com/images/layout-metrics-keylines-keylines-spacing-tablet-01a_large_mdpi.png

Current component have fixed margins regardless on screen size.

The speck does not really define what a mobile or tablet resolution is, with today's devices is hard to tell witch is witch but I do believe that a mediaquery should define few breakpoints.

Thank you.