Closed chunmun closed 9 years ago
To test, erlnmyr device-perf.erlnmyr --chromium=~/chromium/src
Still waiting for https://code.google.com/p/chromium/issues/detail?id=514465 to be resolved. Without --raw-samples, I don't think I can see the samples on about:tracing,
To test this you can physically apply this to your chromium/src
diff --git a/tools/telemetry/telemetry/internal/platform/profiler/perf_profiler.py b/tools/telemetry/telemetry/internal/platform/profiler/perf_profiler.py index 835e9f9..22c5133 100644 --- a/tools/telemetry/telemetry/internal/platform/profiler/perf_profiler.py +++ b/tools/telemetry/telemetry/internal/platform/profiler/perf_profiler.py @@ -28,6 +28,7 @@ _PERF_OPTIONS = [ '-g',
'--freq', '2000',
'--raw-samples' ]
_PERF_OPTIONS_ANDROID = [
Looks like last remaining patch has landed - should I close the bug?
Mun, this is awesome. It's a really clean integration. Thanks heaps! Sorry for taking so long to review.
To test, erlnmyr device-perf.erlnmyr --chromium=~/chromium/src
Still waiting for https://code.google.com/p/chromium/issues/detail?id=514465 to be resolved. Without --raw-samples, I don't think I can see the samples on about:tracing,
To test this you can physically apply this to your chromium/src
diff --git a/tools/telemetry/telemetry/internal/platform/profiler/perf_profiler.py b/tools/telemetry/telemetry/internal/platform/profiler/perf_profiler.py index 835e9f9..22c5133 100644 --- a/tools/telemetry/telemetry/internal/platform/profiler/perf_profiler.py +++ b/tools/telemetry/telemetry/internal/platform/profiler/perf_profiler.py @@ -28,6 +28,7 @@ _PERF_OPTIONS = [ '-g',
Increase sampling frequency for better coverage.
'--raw-samples' ]
_PERF_OPTIONS_ANDROID = [