[ Dartify ] Using type specific to firestore

[tperraut]

The helper dartify is using firestore specific types like GeoPoint forcing to import the firebase-firestore.js dependencie in index.html without actually needing it.

Thank you for your work.

[kevmoo]

Good tip!

On Tue, Dec 1, 2020 at 12:11 PM Thomas Perraut notifications@github.com wrote:

The helper dartify is using firestore specific types like GeoPoint forcing to import the firebase-firestore.js dependencie in index.html without actually needing it.

Thank you for your work.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/FirebaseExtended/firebase-dart/issues/363, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAEFCTX43Z5R2XROYALK43SSVEWTANCNFSM4UJO2QIQ .

[kevmoo]

What happens if you don't include firebase-firestore.js in your app?

[tperraut]

It is spamming with Geopoint missing warnings.

Le mer. 16 déc. 2020 à 22:25, Kevin Moore notifications@github.com a écrit :

What happens if you don't include firebase-firestore.js in your app?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/FirebaseExtended/firebase-dart/issues/363#issuecomment-747047276, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACL5OUZEQCYGG233OL44HZDSVEQUHANCNFSM4UJO2QIQ .

[kevmoo]

In the console? Hrm...

I'm not quite sure what to do here. I could just ignore the cast I guess...hrm...

On Wed, Dec 16, 2020 at 1:27 PM Thomas Perraut notifications@github.com wrote:

It is spamming with Geopoint missing warnings.

Le mer. 16 déc. 2020 à 22:25, Kevin Moore notifications@github.com a écrit :

What happens if you don't include firebase-firestore.js in your app?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/FirebaseExtended/firebase-dart/issues/363#issuecomment-747047276 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACL5OUZEQCYGG233OL44HZDSVEQUHANCNFSM4UJO2QIQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/FirebaseExtended/firebase-dart/issues/363#issuecomment-747049833, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAEFCV6NEYIEXJPIJDWNBTSVEQ3BANCNFSM4UJO2QIQ .

[tperraut]

Yes in the console, pretty problematic in our app as it is really intensive on position changes. I think the dartify helper should not cast to GeoPoint if it is a Firebase realtime object and not a Firestore GeoPoint. I am not an expert of Firestore but for what I understood, a Geopoint is more than a simple object with latitude and longitude as people seems to have issues when creating an object with latitude and longitude and not marking it as a GeoPoint. (cf. https://github.com/FirebaseExtended/firebase-dart/issues/288#issuecomment-705250000) On Firestore you can fix this by marking the actual object as a Geopoint in Firestore but for what I can tell, you cannot do that with Firebase realtime.

[kevmoo]

@tperraut – PR pending.

If you're adventurous, please pull it in as a dependency_override and check to see if it addresses things!