search

googlearchive / generator-angularfire

Yeoman generator for AngularFire: Angular + Firebase apps
191 stars 52 forks source link

update chat ctrl and add bootstrap to chat page. fix wiredep gruntfile issue. #10

Closed mwilc0x closed 9 years ago

mwilc0x commented 9 years ago

Hi,

I added some bootstrap styling to the chat template. I used simpleLogin to retrieve logged in user in chat ctrl and save name along with message in firebase. I moved some init code in the chat controller into an init function. Also, I disabled the chat route when a user is not logged in. Finally, I included a fix for the bower.json wiredep issue when building with grunt. Let me know what you think... thanks.

katowulf commented 9 years ago

Hello Mike! Thanks for the contribution! This is great stuff.

While I really like all the changes you've made here, I'm not sure that this is the best approach. It makes some fundamental assumptions that aren't necessarily true: the app will be using simple login, the app will have bootstrap installed, and the app will be using wiredep 1.9.x.

I labored over many of the same approaches you had here during the implementation and decided to keep things simple for the sake of avoiding bugs. The chat page is more for example than actual implementation, so formatting is not important--just the demonstration of how to link the app's components together.

mwilc0x commented 9 years ago

@katowulf Thank you for the kind feedback! I will keep these things in mind in the future. I am going to play around with the generator some more and build out something with Firebase! Thanks again!