search

googlearchive / generator-angularfire

Yeoman generator for AngularFire: Angular + Firebase apps
190 stars 52 forks source link

removed wrong cwd path in wiredep task #27

Closed gion closed 9 years ago

gion commented 9 years ago

Specifying a cwd option in a task's config makes that directory the "base" directory from which all the operations start.
In this case, having the cwd pointing to the app folder, and simultaneously having app in the filepaths of the subtasks, the wiredep was actually doubling the app folder, searching for files at wrong paths (like app/app/file-name).
I propose this filechange in order to fix the bug and keeping this repo somewhat in sync with the original one.

katowulf commented 9 years ago

How has generator-angular resolved this? We'll just patch our code to match theirs in the near interim, since all of this is derived from their setup.

gion commented 9 years ago

I haven't followed their commit history, but they have totally removed the options property from the wiredep task config.

katowulf commented 9 years ago

Thanks, I've made this change manually to fix the merge conflict.

katowulf commented 9 years ago

Added to the 0.9.1 release. Thanks!