search

googlearchive / generator-angularfire

Yeoman generator for AngularFire: Angular + Firebase apps
191 stars 52 forks source link

Add angularfire config. #3

Closed hijonathan closed 9 years ago

hijonathan commented 9 years ago

I think it needs this. Got an error when trying to install.

katowulf commented 9 years ago

@hijonathan thanks for this, but that isn't correct. The files exist in the root folder of the repo and are not part of the package.json dependencies. Can you explain the error and steps to reproduce?

hijonathan commented 9 years ago

Sure. Try installing the generator and using it on a fresh project and using it. It'll complain that ../angularfire-config.json and ../utils does not exist when trying to require them.

katowulf commented 9 years ago

Check out this related issue: https://github.com/firebase/generator-angularfire/issues/4

hijonathan commented 9 years ago

Yep, that's it. I probably should have been more descriptive.

hijonathan commented 9 years ago

@katowulf btw I'm not an npm expert by any stretch, but the npm docs seem to suggest that my PR will work.

katowulf commented 9 years ago

On review, I think you're right; I missed the critical point that these were part of the files array. Cheers.