Ensure xmppGcmClient thread safety - Githubissues

googlearchive / go-gcm

GCM library for Go.

Apache License 2.0

103 stars 66 forks source link

Ensure xmppGcmClient thread safety #20

Closed bolshoy closed 8 years ago

bolshoy commented 8 years ago

access to messages map is not thread safe
access to isClosed is not thread safe
writing to wire (via XmppClient.SendOrg) is not thread safe

Changes:

added a simple untyped thread-safe map
converted messages map to thread safe
converted xmppClients cache to thread safe
added a lock to xmppGcmClient
access to isClose is now guarded
writing to wire is now guarded and all writes are serialized
some small govet fixes