search

googlearchive / gplus-quickstart-javascript

This quick-start app is built in JavaScript and lets you get started with the Google+ platform in a few minutes.
https://developers.google.com/+/quickstart/javascript
92 stars 111 forks source link

various fixes #15

Closed frank-carnovale closed 8 years ago

frank-carnovale commented 8 years ago 
1. unpredictable timing/no-load problems caused by use of 'defer/async' on script tag.  Possibly
    introduced by Chrome under Windows 10.  Fix was to go back to synchronous load and
    observe advice here: https://developers.google.com/+/web/api/javascript
    which says load the script after defining the appStart function.

2. Surely line 201 supposed to be auth2.then(updateSignIn) not auth2.then(updateSignIn())

3. Logic error in not-signed-in handling: getAuthResponse does not return 'null' it returns an empty object.