googlearchive / js-info-bubble

A library for customizable CSS3 InfoWindows in the Google Maps JavaScript API v3
Apache License 2.0
226 stars 183 forks source link

added "offset" option #24

Open lnx85 opened 8 years ago

lnx85 commented 8 years ago

Use offset: { left: , top: } to shift info window position left and top.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


lnx85 commented 8 years ago

I signed it as VarDump s.r.l. (using staff@var-dump.it)

Il 02/03/16 17:26, googlebot ha scritto:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. |I signed it!|) and we'll verify. Thanks.


— Reply to this email directly or view it on GitHub https://github.com/googlemaps/js-info-bubble/pull/24#issuecomment-191313099.

mpcallahan commented 8 years ago

InfoWindowOptions already has a "pixelOffset" property that references a Size type. https://developers.google.com/maps/documentation/javascript/3.exp/reference#InfoWindowOptions

I'd suggest updating the code to use this, or at least use the same naming (i.e. using "pixelOffset" instead of just "offset" as well as Size's "width"/"height" properties instead of "left"/"top") this would make porting from InfoWindow to InfoBubble easier.