googlearchive / js-marker-clusterer

A marker clustering library for the Google Maps JavaScript API v3.
https://googlemaps.github.io/js-marker-clusterer/docs/reference.html
Apache License 2.0
1.28k stars 775 forks source link

Changed HTTP to HTTPS in image link #11

Closed justinkwanlee closed 8 years ago

justinkwanlee commented 9 years ago

I changed the url for the images to HTTPS, otherwise the browsers will throw an error saying that there are unencrpyted items (for sites that are using HTTPS)

googlebot commented 9 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


justinkwanlee commented 9 years ago

@googlebot I Signed it!

googlebot commented 9 years ago

CLAs look good, thanks!

buren commented 8 years ago

+1, please merge

Tastaturberuf commented 8 years ago

:+1:

XmlmXmlmX commented 8 years ago

+1

Tomtomgo commented 8 years ago

I think it would be better to use '//google-maps-utility-library-v3.googlecode.com/sv...' instead of hard-coding https with 'https://google-maps-utility-library-v3.googlecode.com/sv...'. This way it will not mix http/https.

buren commented 8 years ago

@Tomtomgo what is the harm in loading that over HTTPS even though the page is server over HTTP?

Tomtomgo commented 8 years ago

Instead of forcing HTTP it will now force HTTPS. It's just not necessary.

buren commented 8 years ago

@Tomtomgo sure, I don't see any harm in doing that, just was curious if there was any particular reason :)