Closed justinkwanlee closed 8 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
@googlebot I Signed it!
CLAs look good, thanks!
+1, please merge
:+1:
+1
I think it would be better to use '//google-maps-utility-library-v3.googlecode.com/sv...' instead of hard-coding https with 'https://google-maps-utility-library-v3.googlecode.com/sv...'. This way it will not mix http/https.
@Tomtomgo what is the harm in loading that over HTTPS even though the page is server over HTTP?
Instead of forcing HTTP it will now force HTTPS. It's just not necessary.
@Tomtomgo sure, I don't see any harm in doing that, just was curious if there was any particular reason :)
I changed the url for the images to HTTPS, otherwise the browsers will throw an error saying that there are unencrpyted items (for sites that are using HTTPS)