Open ivanproskuryakov opened 7 years ago
@ivanproskuryakov do you mind creating this PR against our fork at https://github.com/gmaps-marker-clusterer/gmaps-marker-clusterer? This repo isn't maintained anymore. Could you also elaborate what problems we get without clusteringbegin
and clusteringend
?
@Remo
do you mind creating this PR against our fork at https://github.com/gmaps-marker-clusterer/gmaps-marker-clusterer? Sure, will do that
Could you also elaborate what problems we get without clusteringbegin and clusteringend?
This will give possibility to handle events for visible set of clusters only, ex: better performance
// Adding preloading for visible clusters
MapPropertyCollection.prototype.bindClusterEvents = function () {
var _this = this;
google.maps.event.addListener(this.cluster, 'clusteringend', function () {
_this.preloadPreviews();
});
};
// And later, show cached image on mouse over
google.maps.event.addListener(marker, 'mouseover', function () {
infoWindow.open(_this.map, this);
_this.showPreview(marker);
});
Clusters are missing classes which makes impossible to operate(work) with them, like change the opacity of all clusters.
It can be solved by adding class variable programmatically on
tilesloaded
gmaps event, but there are cases when this is not working properly for this "js-marker-clusterer". So I will much better to have separate eventsclusteringbegin
&clusteringend
, similar to: https://github.com/googlemaps/v3-utility-library/blob/master/markerclustererplus/src/markerclusterer.js#L1491 & https://github.com/googlemaps/v3-utility-library/blob/master/markerclustererplus/src/markerclusterer.js#L1536along with class attribute for a marker