googlearchive / js-marker-clusterer

A marker clustering library for the Google Maps JavaScript API v3.
https://googlemaps.github.io/js-marker-clusterer/docs/reference.html
Apache License 2.0
1.28k stars 775 forks source link

Don't push marker if the marker's map is set to null #148

Closed RCady closed 6 years ago

RCady commented 6 years ago

When attempting to filter map markers, the filtered markers still appear.

The widely accepted method of hiding a marker is to use marker.setMap(null). However when using this method in conjunction with the Clusterer, the marker is still pushed to the map regardless of whether or not its map is null.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
RCady commented 6 years ago

I signed it!

googlebot commented 6 years ago

CLAs look good, thanks!