Bower support - Githubissues

googlearchive / js-marker-clusterer

A marker clustering library for the Google Maps JavaScript API v3.

https://googlemaps.github.io/js-marker-clusterer/docs/reference.html

Apache License 2.0

1.28k stars 773 forks source link

Bower support #2

Closed masone closed 9 years ago

masone commented 9 years ago

Requested in #1

Adds bower.json to the repository as described in http://bower.io/docs/creating-packages. Still needs to be registered, see http://bower.io/docs/creating-packages/#register

This is my first bower package definition, so please review thoroughly. Process does not seem to be too complex though and installation via github worked for me.

LoicMahieu commented 9 years ago

bower.json looks fine. It is critical for many team to publish this package on package managers and keep a clean versioning (git tags!). Is there anyone to maintain the project?

LoicMahieu commented 9 years ago

Having bower.json in source is not enough. You need to publish it to bower: http://bower.io/docs/creating-packages/

Unfortunately I see that someone has already taken the package name js-marker-clusterer... https://github.com/Haixing-Hu/js-marker-clusterer owned by @Haixing-Hu

Haixing-Hu commented 9 years ago

Yes，I have forked this repository, added a bower configuration file, and registered it to the bower registry for my personal use.

My fork is exactly the same as the original one, and I will keep it synchronized as much as possible.

If anybody think it should be changed to point to the original repository, I would like to unregister it.

But please give me sometime to do that, because the Chinese GFW blocked bower registry recently. I don't know why the fucking GFW blocks so many technical websites :-( All my previous jumping wall methods, including VPN, Shadowsocks, ssh, etc, were disabled by the recent upgrading of the GFW. I'm still finding a way to jump the wall.

broady commented 9 years ago

OK, thanks, @Haixing-Hu. Update this thread when you have access again :)

Cheers

masone commented 9 years ago

@Haixing-Hu ping

zendre4 commented 8 years ago

Haixing-Hu commented 8 years ago

Hi, I tried to unregister the package, but got the following error:

starfish@Starfishs-iMac:js-marker-clusterer$bower login -t xxxxxxxx(my github token)
bower EAUTH         Logged in as starfish
starfish@Starfishs-iMac:js-marker-clusterer$bower unregister js-marker-clusterer
? You are about to remove component "js-marker-clusterer" from the bower registry (https://bower.herokuapp.com). It is generally considered bad behavior to remove versions of a library that others are depending on. Are you really sure? Yes
bower unregister    js-marker-clusterer
bower EFORBIDDEN    Must have push access to view repository collaborators.

I have spent half an hour to google the answer, without any result :-(

Could anybody help me? @masone