googlearchive / js-marker-clusterer

A marker clustering library for the Google Maps JavaScript API v3.
https://googlemaps.github.io/js-marker-clusterer/docs/reference.html
Apache License 2.0
1.28k stars 772 forks source link

Marker Clusterer icons are gone. Solved. #59

Closed mluis closed 8 years ago

mluis commented 8 years ago

Marker Clusterer icons are gone because they link to the old repository. Changing the URL to the one below solves the issue:

https://raw.githubusercontent.com/googlemaps/js-marker-clusterer/gh-pages/images/m

diogolast commented 8 years ago

thanks!!

ghost commented 8 years ago

Two other issues already mention this (and include solutions): #55 #54

nivas90 commented 8 years ago

When can we expect to see the commit done on the main branch? This is currently breaking our application. Thanks

yannbug commented 8 years ago

+1

djozsef commented 8 years ago

GitHub is not a CDN. You should host the image files on your own and set imagePath option.

mluis commented 8 years ago

@djozsef perhaps the link should be this one?

https://cdn.rawgit.com/googlemaps/js-marker-clusterer/gh-pages/images/m

djozsef commented 8 years ago

@mluis Sound like a plan! I am not sure if it is a proper canonical way but should work even in master as default imagePath.

davidpelayo commented 8 years ago

This unplanned change has caused bugs on thousand of applications. I consider resources shouldn't have been deleted, though.

mluis commented 8 years ago

That's out of my realm but I agree that this should have been a soft handover.

davidpelayo commented 8 years ago

@mluis we have currently thousand of sites published (of our clients) which are visually failing because of this.... I mean, I thought these things were more serious within the different google organization departments...

ghost commented 8 years ago

@davidpelayo I fully understand you, but "failing" is maybe a bit much. The markerclusterer still works, it's just the images that don't show up.

davidpelayo commented 8 years ago

@WACMemphis I agree. It depends on what you mean by saying failing.

However, the responsibility of these actions considering how many people have been using this solution for production-apps it's high enough for double-checking beforehand.

ghost commented 8 years ago

@davidpelayo Yes, I'm with you on this. I have to update quite a few applications myself. I'm opting to use my own images from now on though.

BTW, left a comment on your commit.

brianhogg commented 8 years ago

I've been passing in the MAPPARAMS.imageurl var to set your local path to the images, but the markerclusterer_compiled.js script (or _packed.js in the old version) does not seem to look at this. It appears to be hard coded to the googlecode.com repo.

The attached minified version does the trick. markerclusterer.min.js.zip

wedneyyuri commented 8 years ago

GitHub is not a CDN. You should host the image files on your own and set imagePath option.

In my opinion, the imagePath option should be optional but throw a warning if not passed.

bunnyhero commented 8 years ago

GitHub is not a CDN. You should host the image files on your own and set imagePath option.

It's broken even on the documentation site's example pages :) (e.g. https://googlemaps.github.io/js-marker-clusterer/examples/simple_example.html )

KashifAhmed commented 8 years ago

For time being replace MARKER_CLUSTER_IMAGEPATH with 'https://raw.githubusercontent.com/googlemaps/js-marker-clusterer/gh-pages/images/m'

This trick work for me.

philipdbrown commented 8 years ago

When instantiating the MarkerClusterer, you can pass a new path to the image set with the imagePath option:

var mc = new MarkerClusterer(map, makers, {imagePath: 'https://www.mydomain.com/m'});

that is also a quick fix. Although you can still change the js-marker-cluster, but I like to keep that clean. Just my thoughts.

PeterTheOne commented 8 years ago

fixed by 2f659a3

sudheerec107 commented 7 years ago

Suppose if i have many clusters in my map and i want clusters with different color depending on some value. How to achieve this.

cmcintosh commented 7 years ago

You probably could extend the class for this, im not sure what you would use to decide which cluster gets which icon, but should be a simple addition of a if check.

On 11/29/16 2:03 PM, sudheerkb wrote:

Suppose if i have many clusters in my map and i want clusters with different color depending on some value. How to achieve this.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/googlemaps/js-marker-clusterer/issues/59#issuecomment-263484430, or mute the thread https://github.com/notifications/unsubscribe-auth/ACA0jR4Hyro4Xp7ZKQoYS_zP-jGkdDR9ks5rC8AugaJpZM4IdBxo.

sebastiangug commented 5 years ago

All of the links in this thread are 404 now.

Thanks google.