googlearchive / js-marker-clusterer

A marker clustering library for the Google Maps JavaScript API v3.
https://googlemaps.github.io/js-marker-clusterer/docs/reference.html
Apache License 2.0
1.28k stars 775 forks source link

Marker cluster images URLs updated #61

Closed davidpelayo closed 8 years ago

davidpelayo commented 8 years ago

Fixes #54 and #59, at least what urls are used on this repo.

This doesn't fix those apps with the SVN based codebase which still point to the old repo, due resources aren't available (they have removed them out).

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


davidpelayo commented 8 years ago

Related to #56, #57 and #60.

davidpelayo commented 8 years ago

@WACMemphis I've updated the url to:

MarkerClusterer.prototype.MARKER_CLUSTER_IMAGE_PATH_ =
    'https://googlemaps.github.io/js-marker-clusterer/' +
    'images/m';
googlebot commented 8 years ago

CLAs look good, thanks!

AlaorSilva commented 8 years ago

The only URL that works for me on markerclusterer_compiled.js and markerclusterer.js is https://raw.githubusercontent.com/googlemaps/js-marker-clusterer/gh-pages/images/m

Neither CDN or https://googlemaps.github.io/js-marker-clusterer/ works for me.

When I put one of above the map goes to somewhere else, and I have no markers

ghost commented 8 years ago

@AlaorSilva Works perfectly fine with CDN here. Make sure all of them end with "images/m"

googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

PeterTheOne commented 8 years ago

fixed by 2f659a3