search

googlearchive / k8s-service-catalog

[DEPRECATED] Commandline tool to manage Service Catalog lifecycle and GCP Service Broker atop Kubernetes Cluster
Apache License 2.0
69 stars 31 forks source link

`sc uninstall` should not print out the success message until the namespace is actually removed #114

Closed maqiuyujoyce closed 6 years ago

maqiuyujoyce commented 6 years ago

I ran sc install right after getting the message "uninstalled service catalog successfully", and got the namespace AlreadyExists error:

maqiuyu-macbookpro:installer maqiuyu$ ./output/bin/sc uninstall uninstalled service catalog successfully maqiuyu-macbookpro:installer maqiuyu$ ./output/bin/sc install generated service catalog deployment config in dir: /tmp/service-catalog625681308 Service Catalog could not be installed Error: error deploying YAML files: deploy failed with output: exit status 1 :Error from server (AlreadyExists): error when creating "/tmp/service-catalog625681308/namespace.yaml": object is being deleted: namespaces "service-catalog" already exists

Seems that the deletion of "service-catalog" namespace takes a couple more seconds to finish after command completes.

We should make sure the namespace is actually gone before printing out the success message.

maqiuyujoyce commented 6 years ago

There is already a similar issue: https://github.com/GoogleCloudPlatform/k8s-service-catalog/issues/28