search

googlearchive / k8s-service-catalog

[DEPRECATED] Commandline tool to manage Service Catalog lifecycle and GCP Service Broker atop Kubernetes Cluster
Apache License 2.0
69 stars 31 forks source link

Move broker-cli library into its own top-level directory #73

Closed bmelville closed 6 years ago

bmelville commented 6 years ago

This moves broker-cli out of installer into its own top-level dir. This is in anticipation of introducing the actual broker-cli tool, and vendoring the library in to the installer.

Makes progress on #75.

bmelville commented 6 years ago

@droot for review.

bmelville commented 6 years ago

Just FYI, I am in the process of verifying that sc is still functional for the walk-through.

bmelville commented 6 years ago

@droot I've backed this PR out a bunch, so it is only the move. My guess is I cannot vendor until this is commited so deps can find the package.

bmelville commented 6 years ago

@droot this is a pretty innocuous migration of a small set of code, and while I understand your desire for correctness, your suggestions move from 1-2 PRs to 5. Is there some concrete concern you have here?

bmelville commented 6 years ago

Closing in favor of https://github.com/GoogleCloudPlatform/k8s-service-catalog/pull/89