googlearchive / more-routing

144 stars 30 forks source link

Properly encode/decode parameter values #38

Open gjdev opened 9 years ago

gjdev commented 9 years ago

Allow for path parameters with less trivial values, containing special characters, path-part separators, etc.

googlebot commented 9 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


gjdev commented 9 years ago

I signed it!

googlebot commented 9 years ago

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

gjdev commented 9 years ago

I did author those commits, it's just another email address.

nevir commented 9 years ago

Awesome, thanks!