googlearchive / paper-dialog

A dialog à la Material Design
19 stars 16 forks source link

`.actions` and `.main` containers are in a non-logical order #18

Closed alice closed 9 years ago

alice commented 9 years ago

http://www.w3.org/TR/css3-flexbox/#order-accessibility says "Authors must use order only for visual, not logical, reordering of content; style sheets that use order to perform logical reordering are non-conforming."

Suggestion: swap the order and use select=":not([dismissive]):not([affirmative])" on .actions.

morethanreal commented 9 years ago

I made it that way initially because :not wasn't working in <content select>. It appears to work in Canary now but is not working in polyfill: Polymer/ShadowDOM#485

alice commented 9 years ago

Thanks for the explanation and for following up. (For context, the issue this causes is that screen readers and tab order follow the DOM order rather than the flex order, which I think is debatable but it's what's specced for now.)

morethanreal commented 9 years ago

This is now fixed.