search

googlearchive / paper-dialog

A dialog à la Material Design
19 stars 16 forks source link

Toogle and opened variable #19

Closed kanedafromparis closed 9 years ago

kanedafromparis commented 9 years ago

Don't you think that toggle should switch the opened variable ? Therefore the function should be 

...
toggle: function() {
 if (this.$.opened){this.$.opened=false;}else{this.$.opened=true;};       
this.$.overlay.toggle();
      },
....
morethanreal commented 9 years ago

The opened property in paper-dialog is bound to the same property in core-overlay, so it's unnecessary to set it explicitly in toggle.