search

googlearchive / paper-dialog

A dialog à la Material Design
19 stars 16 forks source link

Remove border override for paper-dialog content #22

Closed jakemac53 closed 9 years ago

jakemac53 commented 9 years ago

See http://www.dartosphere.org/2014/08/25/at-the-bottom-of-the-rabbit-hole-i-find-polyfill-next-selector.html#.U_yWPXWx3UY. I tested it out briefly and don't see a reason for this border: 0; style either. If there is something specific that is trying to be targeted it should probably be put in a less general selector?

morethanreal commented 9 years ago

lgtm, I can't remember why I added the border:0 and it seems to be harmful.

To answer the original post, the reason the original attempt didn't work is ::content > * has higher specificity than paper-button. You could maybe add an id or something to the second selector to give it higher specificity, but that is obviously non ideal :( I think that speaks to the need to take care when writing shadow DOM stylesheets to ensure the element is still themable, etc..

jakemac53 commented 9 years ago

Definitely agree, styling in general is something people seem to struggle with in Polymer and things like this are really easy to sneak in without fully realizing the pain it can potentially cause.