googlearchive / paper-dialog

A dialog à la Material Design
19 stars 16 forks source link

Improperly shaped dialog when there are not affirmative or dismissive buttons #23

Closed EanLombardo closed 9 years ago

EanLombardo commented 9 years ago

If you have no affirmative or dismissive buttons in your dialog, the dialog still shows space at the bottom where affirmative or dismissive buttons would be. The dialog shows up taller than it needs to be.

Because only affirmative or dismissive buttons show up in this space, if you are using your own button that handles dialog dismissal under it's own rules, the extra space shows beneath the button and the whole dialog looks wrong.

morethanreal commented 9 years ago

This should be fixed. paper-dialog does not have special handling for buttons. The new paper-action-dialog should be used if you want buttons.