search

googlearchive / paper-dialog

A dialog à la Material Design
19 stars 16 forks source link

paper-shadow not being applied. #3

Closed ebidel closed 9 years ago

ebidel commented 10 years ago

Running into https://github.com/Polymer/paper-shadow/blob/master/paper-shadow.html#L88:L97 where my dialog doesn't have its paper shadow being applied.

Should default to use hasPosition for the paper-shadow in this element?

screen shot 2014-05-09 at 5 37 52 pm

cc @morethanreal

morethanreal commented 10 years ago

Yes, you should use hasPosition if paper-shadow is incorrectly overwriting your position property.

Do you have a test case for when it fails for you? I would like to look into it further, but my test case no longer shows the issue.

ebidel commented 10 years ago

Just pulled the latest. It's working on 35.0.1916.99 beta but not Canary. The only thing different about Canary is that HTML Imports are on and Object.observe is on.

paper-shadow is internal to the dialog element, so I can't set it manually.

morethanreal commented 9 years ago

Is this still reproducible?

ebidel commented 9 years ago

Don't think so. The dialogs on http://ebidel.github.io/material-playground/ are working as expected.