googlearchive / paper-dialog

A dialog à la Material Design
19 stars 16 forks source link

Add import to transition module #34

Closed orva closed 9 years ago

orva commented 9 years ago

This commit fixes issue #32. This was triggered because paper-dialog had hard dependency to the paper-dialog-transition component, even though documentation said it was optional. We fix this by importing transition component from paper-dialog and updating documentation to reflect the change.

Documentation now also highlights transition attribute in examples to make them more visible in component description page, as currently the values of transition attributes are clipped.

ebidel commented 9 years ago

Before this PR can be merged, please sign the CLA. See the CONTRIBUTING guide.

orva commented 9 years ago

I have signed CLA, but do I need to do PR myself to CONTRIBUTERS or is CLA alone enough?

ebidel commented 9 years ago

Confirmed you've signed.

morethanreal commented 9 years ago

Fixed in another commit.