search

googlearchive / paper-dialog

A dialog à la Material Design
19 stars 16 forks source link

Update paper-dialog and paper-action-dialog to support light dom headings #48

Closed benjaminapetersen closed 8 years ago

benjaminapetersen commented 9 years ago

References issue #46
Update paper-dialog and paper-action-dialog to support light dom headings

benjaminapetersen commented 9 years ago

Feel free to comment, especially if something doesn't work. I made changes in a mini-project then migrated to my branch here since the paper-dialog repo doesn't contain everything it needs to run the code. I probably should have thought up a better way to do that.

Full link to the issue I created the other day: https://github.com/Polymer/paper-dialog/issues/46

benjaminapetersen commented 9 years ago

Also references issue #45. I provided a sample in the demo.html of a rounded dialog.

benjaminapetersen commented 9 years ago

styled_dialog_with_light_dom_headings

Screenshot may be helpful to illustrate what this accomplishes.

ssorallen commented 9 years ago

The output of the content in your examples is the same if paper-dialog simply removes its <content id="heading" select=".heading"></content> container. It seems more beneficial to defer to the user to manage the content of a paper-dialog rather than add features for specific use cases.

benjaminapetersen commented 8 years ago

Agree, and this is probably long expired now that Polymer is upto 1.0!

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.