search

googlearchive / paper-menu-button

An icon button that opens a drop-down menu for use in toolbars, etc.
9 stars 7 forks source link

paper-menu-button theming should be aligned with paper-dropdown-menu #52

Closed kenmoore closed 10 years ago

kenmoore commented 10 years ago

paper-dropdown-menu allows you to set text and background color with: 

paper-dropdown-menu::shadow #dropdown {
    color: purple;
    background-color: #eee;
}

ALSO, paper-menu-button allows you to set the text and background color similarly:

  paper-menu-button::shadow #menu {
    color: lightpink;
    background-color: lightgreen;
  }

PROPOSE: 1) align the shadow element id ('menu' is preferable to 'dropdown' since it's the common word in the name of both elements)

2) remove this part of the documentation, as it is not necessary (user can currently use color property with the #menu selector as shown above) and doesn't conform to class names of other paper elements:

paper-menu-button::shadow .paper-menu-button-overlay-bg { background: green; }

morethanreal commented 10 years ago

I think this issue does not apply to the new API for this element. You now provide a paper-dropdown to the menu button and style the dropdown/menu independently.