search

googlearchive / paper-menu

A Material Design menu
https://www.webcomponents.org/element/PolymerElements/paper-menu
27 stars 48 forks source link

_active -> opened #107

Closed danbeam closed 7 years ago

danbeam commented 7 years ago

fixes https://github.com/PolymerElements/paper-menu/issues/88

danbeam commented 7 years ago

@notwaldorf @tjsavage @bicknellr can haz review?

danbeam commented 7 years ago

Could you add a test that checks that one tap is necessary to close a paper-submenu with opened true?

Done (but wait, there's more!)

danbeam commented 7 years ago

if my constant git push -f isn't clear (because it seems to kinda mess with github), this has done all your review requests and I've updated tests to catch a whole bunch of things

danbeam commented 7 years ago

thanks for working with me on this @bicknellr! glad we were able to fix this for existing users!

bicknellr commented 7 years ago

np, sorry about the long delay, context switching between all of the elements is a bit tough.