search

googlearchive / paper-menu

A Material Design menu
https://www.webcomponents.org/element/PolymerElements/paper-menu
27 stars 48 forks source link

Fix A11y: #44 #51

Closed blasten closed 8 years ago

blasten commented 8 years ago

Original issue #44

samccone commented 8 years ago

looks like we need a rebase :jack_o_lantern:

blasten commented 8 years ago

rebased!

blasten commented 8 years ago

friendly ping @cdata @notwaldorf

cdata commented 8 years ago

Since this fixes an issue, would it be possible to add a test that might catch regressions?

cdata commented 8 years ago

This PR is looking really nice and clean. I left you some feedback. PTAL!

cdata commented 8 years ago

@blasten bump

blasten commented 8 years ago

@cdata I added a test PTAL

cdata commented 8 years ago

LGTM :+1: Thanks for bearing with me on this one!

blasten commented 8 years ago

🙏