Closed tuxracer closed 8 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I signed it!
CLAs look good, thanks!
@tuxracer I don't see where a color from color.html
is used in paper-menu
, or paper-menu-shared-styles
, so I don't know why this import is needed
Ah, --dark-divider-opacity
. I originally thought that was from default-theme.html
. My bad!
@tuxracer I think you might need to add this to paper-submenu
as well.
Thanks!
(I think the test failures are unrelated, since they're happening on master as well. Opened https://github.com/PolymerElements/paper-menu/issues/63)
Thank you for fixing this! Are we planning a 1.2.1 anytime soonishish? :cat:
@notwaldorf ack good catch on paper-submenu
@addyosmani no problem!
Closes #61