googlearchive / paper-menu

A Material Design menu
https://www.webcomponents.org/element/PolymerElements/paper-menu
27 stars 48 forks source link

Import paper-styles/color.html to fix wrong opacity on focus #62

Closed tuxracer closed 8 years ago

tuxracer commented 8 years ago

Closes #61

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


tuxracer commented 8 years ago

I signed it!

googlebot commented 8 years ago

CLAs look good, thanks!

notwaldorf commented 8 years ago

@tuxracer I don't see where a color from color.html is used in paper-menu, or paper-menu-shared-styles, so I don't know why this import is needed

notwaldorf commented 8 years ago

Ah, --dark-divider-opacity. I originally thought that was from default-theme.html. My bad!

notwaldorf commented 8 years ago

@tuxracer I think you might need to add this to paper-submenu as well.

notwaldorf commented 8 years ago

Thanks!

notwaldorf commented 8 years ago

(I think the test failures are unrelated, since they're happening on master as well. Opened https://github.com/PolymerElements/paper-menu/issues/63)

addyosmani commented 8 years ago

Thank you for fixing this! Are we planning a 1.2.1 anytime soonishish? :cat:

tuxracer commented 8 years ago

@notwaldorf ack good catch on paper-submenu @addyosmani no problem!